View Issue Details

Jump to NotesJump to History
IDProjectCategoryView StatusDate SubmittedLast Update
0000959channel: elrepo/el8--elrepo--request-for-enhancement--public2019-10-22 11:312019-12-08 05:28
Reporterpseud Assigned Topperry  
PrioritynormalSeverityfeatureReproducibilityN/A
Status resolvedResolutionfixed 
Summary0000959: Wireless device modules iwl3945 and iwl4965 have been removed in el8
Descriptionhttps://access.redhat.com/documentation/en-us/red_hat_enterprise_linux/8/html/considerations_in_adopting_rhel_8/hardware-enablement_considerations-in-adopting-rhel-8#removed-device-drivers_hardware-enablement
11.1.1. Removed device drivers
...
 *wireless drivers:
    *carl9170
    *iwl4965
    *iwl3945
    ...

Please provide the above the iwlegacy driver for the above:
https://wireless.wiki.kernel.org/en/users/drivers/iwlegacy
Additional Informationhttps://bugs.centos.org/view.php?id=16635
TagsNo tags attached.
Attached Files
bug959-errors.txt (40,802 bytes)    
/home/phil/rpmbuild/BUILD/iwlegacy-0.0/4965-debug.c: In function 'il4965_ucode_rx_stats_read':
/home/phil/rpmbuild/BUILD/iwlegacy-0.0/4965-debug.c:90:12: error: 'struct il_priv' has no member named '_4965'
  ofdm = &il->_4965.stats.rx.ofdm;
            ^~
/home/phil/rpmbuild/BUILD/iwlegacy-0.0/4965-debug.c:91:11: error: 'struct il_priv' has no member named '_4965'
  cck = &il->_4965.stats.rx.cck;
           ^~
/home/phil/rpmbuild/BUILD/iwlegacy-0.0/4965-debug.c:92:15: error: 'struct il_priv' has no member named '_4965'
  general = &il->_4965.stats.rx.general;
               ^~
/home/phil/rpmbuild/BUILD/iwlegacy-0.0/4965-debug.c:93:10: error: 'struct il_priv' has no member named '_4965'
  ht = &il->_4965.stats.rx.ofdm_ht;
          ^~
/home/phil/rpmbuild/BUILD/iwlegacy-0.0/4965-debug.c:94:18: error: 'struct il_priv' has no member named '_4965'
  accum_ofdm = &il->_4965.accum_stats.rx.ofdm;
                  ^~
/home/phil/rpmbuild/BUILD/iwlegacy-0.0/4965-debug.c:95:17: error: 'struct il_priv' has no member named '_4965'
  accum_cck = &il->_4965.accum_stats.rx.cck;
                 ^~
/home/phil/rpmbuild/BUILD/iwlegacy-0.0/4965-debug.c:96:21: error: 'struct il_priv' has no member named '_4965'
  accum_general = &il->_4965.accum_stats.rx.general;
                     ^~
/home/phil/rpmbuild/BUILD/iwlegacy-0.0/4965-debug.c:97:16: error: 'struct il_priv' has no member named '_4965'
  accum_ht = &il->_4965.accum_stats.rx.ofdm_ht;
                ^~
/home/phil/rpmbuild/BUILD/iwlegacy-0.0/4965-debug.c:98:18: error: 'struct il_priv' has no member named '_4965'
  delta_ofdm = &il->_4965.delta_stats.rx.ofdm;
                  ^~
/home/phil/rpmbuild/BUILD/iwlegacy-0.0/4965-debug.c:99:17: error: 'struct il_priv' has no member named '_4965'
  delta_cck = &il->_4965.delta_stats.rx.cck;
                 ^~
/home/phil/rpmbuild/BUILD/iwlegacy-0.0/4965-debug.c:100:21: error: 'struct il_priv' has no member named '_4965'
  delta_general = &il->_4965.delta_stats.rx.general;
                     ^~
/home/phil/rpmbuild/BUILD/iwlegacy-0.0/4965-debug.c:101:16: error: 'struct il_priv' has no member named '_4965'
  delta_ht = &il->_4965.delta_stats.rx.ofdm_ht;
                ^~
/home/phil/rpmbuild/BUILD/iwlegacy-0.0/4965-debug.c:102:16: error: 'struct il_priv' has no member named '_4965'
  max_ofdm = &il->_4965.max_delta.rx.ofdm;
                ^~
/home/phil/rpmbuild/BUILD/iwlegacy-0.0/4965-debug.c:103:15: error: 'struct il_priv' has no member named '_4965'
  max_cck = &il->_4965.max_delta.rx.cck;
               ^~
/home/phil/rpmbuild/BUILD/iwlegacy-0.0/4965-debug.c:104:19: error: 'struct il_priv' has no member named '_4965'
  max_general = &il->_4965.max_delta.rx.general;
                   ^~
/home/phil/rpmbuild/BUILD/iwlegacy-0.0/4965-debug.c:105:14: error: 'struct il_priv' has no member named '_4965'
  max_ht = &il->_4965.max_delta.rx.ofdm_ht;
              ^~
/home/phil/rpmbuild/BUILD/iwlegacy-0.0/3945-mac.c: In function 'il3945_unset_hw_params':
/home/phil/rpmbuild/BUILD/iwlegacy-0.0/3945-mac.c:358:8: error: 'struct il_priv' has no member named '_3945'
  if (il->_3945.shared_virt)
        ^~
/home/phil/rpmbuild/BUILD/iwlegacy-0.0/3945-mac.c:361:9: error: 'struct il_priv' has no member named '_3945'
       il->_3945.shared_virt, il->_3945.shared_phys);
         ^~
/home/phil/rpmbuild/BUILD/iwlegacy-0.0/3945-mac.c:361:32: error: 'struct il_priv' has no member named '_3945'
       il->_3945.shared_virt, il->_3945.shared_phys);
                                ^~
/home/phil/rpmbuild/BUILD/iwlegacy-0.0/4965-mac.c: In function 'il4965_hdl_rx':
/home/phil/rpmbuild/BUILD/iwlegacy-0.0/4965-mac.c:659:10: error: 'struct il_priv' has no member named '_4965'
   if (!il->_4965.last_phy_res_valid) {
          ^~
/home/phil/rpmbuild/BUILD/iwlegacy-0.0/4965-mac.c:663:16: error: 'struct il_priv' has no member named '_4965'
   phy_res = &il->_4965.last_phy_res;
                ^~
/home/phil/rpmbuild/BUILD/iwlegacy-0.0/4965-debug.c: In function 'il4965_ucode_tx_stats_read':
/home/phil/rpmbuild/BUILD/iwlegacy-0.0/4965-debug.c:494:10: error: 'struct il_priv' has no member named '_4965'
  tx = &il->_4965.stats.tx;
          ^~
/home/phil/rpmbuild/BUILD/iwlegacy-0.0/4965-debug.c:495:16: error: 'struct il_priv' has no member named '_4965'
  accum_tx = &il->_4965.accum_stats.tx;
                ^~
/home/phil/rpmbuild/BUILD/iwlegacy-0.0/4965-debug.c:496:16: error: 'struct il_priv' has no member named '_4965'
  delta_tx = &il->_4965.delta_stats.tx;
                ^~
/home/phil/rpmbuild/BUILD/iwlegacy-0.0/4965-debug.c:497:14: error: 'struct il_priv' has no member named '_4965'
  max_tx = &il->_4965.max_delta.tx;
              ^~
/home/phil/rpmbuild/BUILD/iwlegacy-0.0/4965-mac.c:750:33: error: 'struct il_priv' has no member named '_4965'
   rx_status.ampdu_reference = il->_4965.ampdu_ref;
                                 ^~
/home/phil/rpmbuild/BUILD/iwlegacy-0.0/4965-mac.c: In function 'il4965_hdl_rx_phy':
/home/phil/rpmbuild/BUILD/iwlegacy-0.0/4965-mac.c:763:4: error: 'struct il_priv' has no member named '_4965'
  il->_4965.last_phy_res_valid = true;
    ^~
/home/phil/rpmbuild/BUILD/iwlegacy-0.0/4965-mac.c:764:4: error: 'struct il_priv' has no member named '_4965'
  il->_4965.ampdu_ref++;
    ^~
/home/phil/rpmbuild/BUILD/iwlegacy-0.0/4965-mac.c:765:12: error: 'struct il_priv' has no member named '_4965'
  memcpy(&il->_4965.last_phy_res, pkt->u.raw,
            ^~
/home/phil/rpmbuild/BUILD/iwlegacy-0.0/3945-mac.c: In function 'il3945_get_measurement':
/home/phil/rpmbuild/BUILD/iwlegacy-0.0/3945-mac.c:682:8: error: 'struct il_priv' has no member named '_3945'
      il->_3945.last_tsf,
        ^~
/home/phil/rpmbuild/BUILD/iwlegacy-0.0/3945-mac.c:696:32: error: 'struct il_priv' has no member named '_3945'
       il_add_beacon_time(il, il->_3945.last_beacon_time, add_time,
                                ^~
/home/phil/rpmbuild/BUILD/iwlegacy-0.0/4965-debug.c: In function 'il4965_ucode_general_stats_read':
/home/phil/rpmbuild/BUILD/iwlegacy-0.0/4965-debug.c:663:15: error: 'struct il_priv' has no member named '_4965'
  general = &il->_4965.stats.general.common;
               ^~
/home/phil/rpmbuild/BUILD/iwlegacy-0.0/4965-debug.c:664:11: error: 'struct il_priv' has no member named '_4965'
  dbg = &il->_4965.stats.general.common.dbg;
           ^~
/home/phil/rpmbuild/BUILD/iwlegacy-0.0/4965-debug.c:665:11: error: 'struct il_priv' has no member named '_4965'
  div = &il->_4965.stats.general.common.div;
           ^~
/home/phil/rpmbuild/BUILD/iwlegacy-0.0/4965-debug.c:666:21: error: 'struct il_priv' has no member named '_4965'
  accum_general = &il->_4965.accum_stats.general.common;
                     ^~
/home/phil/rpmbuild/BUILD/iwlegacy-0.0/4965-debug.c:667:17: error: 'struct il_priv' has no member named '_4965'
  accum_dbg = &il->_4965.accum_stats.general.common.dbg;
                 ^~
/home/phil/rpmbuild/BUILD/iwlegacy-0.0/4965-debug.c:668:17: error: 'struct il_priv' has no member named '_4965'
  accum_div = &il->_4965.accum_stats.general.common.div;
                 ^~
/home/phil/rpmbuild/BUILD/iwlegacy-0.0/4965-debug.c:669:21: error: 'struct il_priv' has no member named '_4965'
  delta_general = &il->_4965.delta_stats.general.common;
                     ^~
/home/phil/rpmbuild/BUILD/iwlegacy-0.0/4965-debug.c:670:19: error: 'struct il_priv' has no member named '_4965'
  max_general = &il->_4965.max_delta.general.common;
                   ^~
/home/phil/rpmbuild/BUILD/iwlegacy-0.0/4965-debug.c:671:17: error: 'struct il_priv' has no member named '_4965'
  delta_dbg = &il->_4965.delta_stats.general.common.dbg;
                 ^~
/home/phil/rpmbuild/BUILD/iwlegacy-0.0/4965-debug.c:672:15: error: 'struct il_priv' has no member named '_4965'
  max_dbg = &il->_4965.max_delta.general.common.dbg;
               ^~
/home/phil/rpmbuild/BUILD/iwlegacy-0.0/4965-debug.c:673:17: error: 'struct il_priv' has no member named '_4965'
  delta_div = &il->_4965.delta_stats.general.common.div;
                 ^~
/home/phil/rpmbuild/BUILD/iwlegacy-0.0/4965-debug.c:674:15: error: 'struct il_priv' has no member named '_4965'
  max_div = &il->_4965.max_delta.general.common.div;
               ^~
/home/phil/rpmbuild/BUILD/iwlegacy-0.0/4965-debug.c: At top level:
/home/phil/rpmbuild/BUILD/iwlegacy-0.0/4965-debug.c:748:14: error: variable 'il4965_debugfs_ops' has initializer but incomplete type
 const struct il_debugfs_ops il4965_debugfs_ops = {
              ^~~~~~~~~~~~~~
/home/phil/rpmbuild/BUILD/iwlegacy-0.0/4965-debug.c:749:3: error: 'const struct il_debugfs_ops' has no member named 'rx_stats_read'
  .rx_stats_read = il4965_ucode_rx_stats_read,
   ^~~~~~~~~~~~~
/home/phil/rpmbuild/BUILD/iwlegacy-0.0/4965-debug.c:749:19: warning: excess elements in struct initializer
  .rx_stats_read = il4965_ucode_rx_stats_read,
                   ^~~~~~~~~~~~~~~~~~~~~~~~~~
/home/phil/rpmbuild/BUILD/iwlegacy-0.0/4965-debug.c:749:19: note: (near initialization for 'il4965_debugfs_ops')
/home/phil/rpmbuild/BUILD/iwlegacy-0.0/4965-debug.c:750:3: error: 'const struct il_debugfs_ops' has no member named 'tx_stats_read'
  .tx_stats_read = il4965_ucode_tx_stats_read,
   ^~~~~~~~~~~~~
/home/phil/rpmbuild/BUILD/iwlegacy-0.0/4965-debug.c:750:19: warning: excess elements in struct initializer
  .tx_stats_read = il4965_ucode_tx_stats_read,
                   ^~~~~~~~~~~~~~~~~~~~~~~~~~
/home/phil/rpmbuild/BUILD/iwlegacy-0.0/4965-debug.c:750:19: note: (near initialization for 'il4965_debugfs_ops')
/home/phil/rpmbuild/BUILD/iwlegacy-0.0/4965-debug.c:751:3: error: 'const struct il_debugfs_ops' has no member named 'general_stats_read'
  .general_stats_read = il4965_ucode_general_stats_read,
   ^~~~~~~~~~~~~~~~~~
/home/phil/rpmbuild/BUILD/iwlegacy-0.0/4965-debug.c:751:24: warning: excess elements in struct initializer
  .general_stats_read = il4965_ucode_general_stats_read,
                        ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/home/phil/rpmbuild/BUILD/iwlegacy-0.0/4965-debug.c:751:24: note: (near initialization for 'il4965_debugfs_ops')
/home/phil/rpmbuild/BUILD/iwlegacy-0.0/4965-debug.c:748:29: error: storage size of 'il4965_debugfs_ops' isn't known
 const struct il_debugfs_ops il4965_debugfs_ops = {
                             ^~~~~~~~~~~~~~~~~~
/home/phil/rpmbuild/BUILD/iwlegacy-0.0/4965.c: In function 'il4965_hw_get_temperature':
/home/phil/rpmbuild/BUILD/iwlegacy-0.0/4965.c:1585:9: error: 'struct il_priv' has no member named '_4965'
      (il->_4965.stats.flag & STATS_REPLY_FLG_HT40_MODE_MSK)) {
         ^~
In file included from ./include/linux/byteorder/little_endian.h:5,
                 from ./arch/x86/include/uapi/asm/byteorder.h:5,
                 from ./include/asm-generic/bitops/le.h:6,
                 from ./arch/x86/include/asm/bitops.h:521,
                 from ./include/linux/bitops.h:38,
                 from ./include/linux/kernel.h:11,
                 from /home/phil/rpmbuild/BUILD/iwlegacy-0.0/4965.c:27:
/home/phil/rpmbuild/BUILD/iwlegacy-0.0/4965.c:1610:11: error: 'struct il_priv' has no member named '_4965'
        (il->_4965.stats.general.common.temperature),
           ^~
./include/uapi/linux/byteorder/little_endian.h:34:51: note: in definition of macro '__le32_to_cpu'
 #define __le32_to_cpu(x) ((__force __u32)(__le32)(x))
                                                   ^
/home/phil/rpmbuild/BUILD/iwlegacy-0.0/4965.c:1609:22: note: in expansion of macro 'le32_to_cpu'
   vt = sign_extend32(le32_to_cpu
                      ^~~~~~~~~~~
/home/phil/rpmbuild/BUILD/iwlegacy-0.0/4965-mac.c: In function 'il4965_rx_calc_noise':
/home/phil/rpmbuild/BUILD/iwlegacy-0.0/4965-mac.c:1296:16: error: 'struct il_priv' has no member named '_4965'
  rx_info = &(il->_4965.stats.rx.general);
                ^~
/home/phil/rpmbuild/BUILD/iwlegacy-0.0/4965-mac.c: In function 'il4965_hdl_stats':
/home/phil/rpmbuild/BUILD/iwlegacy-0.0/4965-mac.c:1384:10: error: 'struct il_priv' has no member named '_4965'
      ((il->_4965.stats.general.common.temperature !=
          ^~
/home/phil/rpmbuild/BUILD/iwlegacy-0.0/4965-mac.c:1386:11: error: 'struct il_priv' has no member named '_4965'
       ((il->_4965.stats.flag & STATS_REPLY_FLG_HT40_MODE_MSK) !=
           ^~
/home/phil/rpmbuild/BUILD/iwlegacy-0.0/4965-mac.c:1393:12: error: 'struct il_priv' has no member named '_4965'
  memcpy(&il->_4965.stats, &pkt->u.stats, sizeof(il->_4965.stats));
            ^~
/home/phil/rpmbuild/BUILD/iwlegacy-0.0/4965-mac.c:1393:51: error: 'struct il_priv' has no member named '_4965'
  memcpy(&il->_4965.stats, &pkt->u.stats, sizeof(il->_4965.stats));
                                                   ^~
/home/phil/rpmbuild/BUILD/iwlegacy-0.0/debug.c:46:1: error: redefinition of 'il_update_stats'
 il_update_stats(struct il_priv *il, bool is_tx, __le16 fc, u16 len)
 ^~~~~~~~~~~~~~~
In file included from /home/phil/rpmbuild/BUILD/iwlegacy-0.0/debug.c:32:
/home/phil/rpmbuild/BUILD/iwlegacy-0.0/common.h:1736:1: note: previous definition of 'il_update_stats' was here
 il_update_stats(struct il_priv *il, bool is_tx, __le16 fc, u16 len)
 ^~~~~~~~~~~~~~~
/home/phil/rpmbuild/BUILD/iwlegacy-0.0/debug.c: In function 'il_update_stats':
/home/phil/rpmbuild/BUILD/iwlegacy-0.0/debug.c:58:9: error: 'struct traffic_stats' has no member named 'mgmt'
    stats->mgmt[MANAGEMENT_ASSOC_REQ]++;
         ^~
/home/phil/rpmbuild/BUILD/iwlegacy-0.0/debug.c:61:9: error: 'struct traffic_stats' has no member named 'mgmt'
    stats->mgmt[MANAGEMENT_ASSOC_RESP]++;
         ^~
/home/phil/rpmbuild/BUILD/iwlegacy-0.0/debug.c:64:9: error: 'struct traffic_stats' has no member named 'mgmt'
    stats->mgmt[MANAGEMENT_REASSOC_REQ]++;
         ^~
/home/phil/rpmbuild/BUILD/iwlegacy-0.0/debug.c:67:9: error: 'struct traffic_stats' has no member named 'mgmt'
    stats->mgmt[MANAGEMENT_REASSOC_RESP]++;
         ^~
/home/phil/rpmbuild/BUILD/iwlegacy-0.0/debug.c:70:9: error: 'struct traffic_stats' has no member named 'mgmt'
    stats->mgmt[MANAGEMENT_PROBE_REQ]++;
         ^~
/home/phil/rpmbuild/BUILD/iwlegacy-0.0/debug.c:73:9: error: 'struct traffic_stats' has no member named 'mgmt'
    stats->mgmt[MANAGEMENT_PROBE_RESP]++;
         ^~
/home/phil/rpmbuild/BUILD/iwlegacy-0.0/debug.c:76:9: error: 'struct traffic_stats' has no member named 'mgmt'
    stats->mgmt[MANAGEMENT_BEACON]++;
         ^~
/home/phil/rpmbuild/BUILD/iwlegacy-0.0/debug.c:79:9: error: 'struct traffic_stats' has no member named 'mgmt'
    stats->mgmt[MANAGEMENT_ATIM]++;
         ^~
/home/phil/rpmbuild/BUILD/iwlegacy-0.0/debug.c:82:9: error: 'struct traffic_stats' has no member named 'mgmt'
    stats->mgmt[MANAGEMENT_DISASSOC]++;
         ^~
/home/phil/rpmbuild/BUILD/iwlegacy-0.0/debug.c:85:9: error: 'struct traffic_stats' has no member named 'mgmt'
    stats->mgmt[MANAGEMENT_AUTH]++;
         ^~
/home/phil/rpmbuild/BUILD/iwlegacy-0.0/debug.c:88:9: error: 'struct traffic_stats' has no member named 'mgmt'
    stats->mgmt[MANAGEMENT_DEAUTH]++;
         ^~
/home/phil/rpmbuild/BUILD/iwlegacy-0.0/debug.c:91:9: error: 'struct traffic_stats' has no member named 'mgmt'
    stats->mgmt[MANAGEMENT_ACTION]++;
         ^~
/home/phil/rpmbuild/BUILD/iwlegacy-0.0/debug.c:97:9: error: 'struct traffic_stats' has no member named 'ctrl'
    stats->ctrl[CONTROL_BACK_REQ]++;
         ^~
/home/phil/rpmbuild/BUILD/iwlegacy-0.0/debug.c:100:9: error: 'struct traffic_stats' has no member named 'ctrl'
    stats->ctrl[CONTROL_BACK]++;
         ^~
/home/phil/rpmbuild/BUILD/iwlegacy-0.0/debug.c:103:9: error: 'struct traffic_stats' has no member named 'ctrl'
    stats->ctrl[CONTROL_PSPOLL]++;
         ^~
/home/phil/rpmbuild/BUILD/iwlegacy-0.0/debug.c:106:9: error: 'struct traffic_stats' has no member named 'ctrl'
    stats->ctrl[CONTROL_RTS]++;
         ^~
/home/phil/rpmbuild/BUILD/iwlegacy-0.0/debug.c:109:9: error: 'struct traffic_stats' has no member named 'ctrl'
    stats->ctrl[CONTROL_CTS]++;
         ^~
/home/phil/rpmbuild/BUILD/iwlegacy-0.0/debug.c:112:9: error: 'struct traffic_stats' has no member named 'ctrl'
    stats->ctrl[CONTROL_ACK]++;
         ^~
/home/phil/rpmbuild/BUILD/iwlegacy-0.0/debug.c:115:9: error: 'struct traffic_stats' has no member named 'ctrl'
    stats->ctrl[CONTROL_CFEND]++;
         ^~
/home/phil/rpmbuild/BUILD/iwlegacy-0.0/debug.c:118:9: error: 'struct traffic_stats' has no member named 'ctrl'
    stats->ctrl[CONTROL_CFENDACK]++;
         ^~
/home/phil/rpmbuild/BUILD/iwlegacy-0.0/debug.c:123:8: error: 'struct traffic_stats' has no member named 'data_cnt'
   stats->data_cnt++;
        ^~
/home/phil/rpmbuild/BUILD/iwlegacy-0.0/debug.c:124:8: error: 'struct traffic_stats' has no member named 'data_bytes'
   stats->data_bytes += len;
        ^~
/home/phil/rpmbuild/BUILD/iwlegacy-0.0/debug.c: In function 'il_dbgfs_tx_stats_read':
/home/phil/rpmbuild/BUILD/iwlegacy-0.0/debug.c:248:47: error: 'struct traffic_stats' has no member named 'mgmt'
          il_get_mgmt_string(cnt), il->tx_stats.mgmt[cnt]);
                                               ^
/home/phil/rpmbuild/BUILD/iwlegacy-0.0/debug.c:254:47: error: 'struct traffic_stats' has no member named 'ctrl'
          il_get_ctrl_string(cnt), il->tx_stats.ctrl[cnt]);
                                               ^
/home/phil/rpmbuild/BUILD/iwlegacy-0.0/debug.c:259:21: error: 'struct traffic_stats' has no member named 'data_cnt'
         il->tx_stats.data_cnt);
                     ^
/home/phil/rpmbuild/BUILD/iwlegacy-0.0/debug.c:262:21: error: 'struct traffic_stats' has no member named 'data_bytes'
         il->tx_stats.data_bytes);
                     ^
In file included from ./include/linux/kernel.h:10,
                 from /home/phil/rpmbuild/BUILD/iwlegacy-0.0/3945-mac.c:32:
/home/phil/rpmbuild/BUILD/iwlegacy-0.0/3945-mac.c: In function 'il3945_rfkill_poll':
/home/phil/rpmbuild/BUILD/iwlegacy-0.0/debug.c: In function 'il_dbgfs_rx_stats_read':
/home/phil/rpmbuild/BUILD/iwlegacy-0.0/debug.c:309:47: error: 'struct traffic_stats' has no member named 'mgmt'
          il_get_mgmt_string(cnt), il->rx_stats.mgmt[cnt]);
                                               ^
/home/phil/rpmbuild/BUILD/iwlegacy-0.0/debug.c:315:47: error: 'struct traffic_stats' has no member named 'ctrl'
          il_get_ctrl_string(cnt), il->rx_stats.ctrl[cnt]);
                                               ^
/home/phil/rpmbuild/BUILD/iwlegacy-0.0/debug.c:320:21: error: 'struct traffic_stats' has no member named 'data_cnt'
         il->rx_stats.data_cnt);
                     ^
/home/phil/rpmbuild/BUILD/iwlegacy-0.0/debug.c:323:21: error: 'struct traffic_stats' has no member named 'data_bytes'
         il->rx_stats.data_bytes);
                     ^
./include/linux/kernel.h:1012:51: error: 'struct il_priv' has no member named '_3945'
  BUILD_BUG_ON_MSG(!__same_type(*(ptr), ((type *)0)->member) && \
                                                   ^~
./include/linux/compiler.h:316:19: note: in definition of macro '__compiletime_assert'
   bool __cond = !(condition); \
                   ^~~~~~~~~
./include/linux/compiler.h:339:2: note: in expansion of macro '_compiletime_assert'
  _compiletime_assert(condition, msg, __compiletime_assert_, __LINE__)
  ^~~~~~~~~~~~~~~~~~~
./include/linux/build_bug.h:45:37: note: in expansion of macro 'compiletime_assert'
 #define BUILD_BUG_ON_MSG(cond, msg) compiletime_assert(!(cond), msg)
                                     ^~~~~~~~~~~~~~~~~~
./include/linux/kernel.h:1012:2: note: in expansion of macro 'BUILD_BUG_ON_MSG'
  BUILD_BUG_ON_MSG(!__same_type(*(ptr), ((type *)0)->member) && \
  ^~~~~~~~~~~~~~~~
./include/linux/kernel.h:1012:20: note: in expansion of macro '__same_type'
  BUILD_BUG_ON_MSG(!__same_type(*(ptr), ((type *)0)->member) && \
                    ^~~~~~~~~~~
/home/phil/rpmbuild/BUILD/iwlegacy-0.0/3945-mac.c:2503:6: note: in expansion of macro 'container_of'
      container_of(data, struct il_priv, _3945.rfkill_poll.work);
      ^~~~~~~~~~~~
In file included from ././include/linux/compiler_types.h:58,
                 from <command-line>:
./include/linux/compiler-gcc.h:185:2: error: 'struct il_priv' has no member named '_3945'
  __builtin_offsetof(a, b)
  ^~~~~~~~~~~~~~~~~~
./include/linux/stddef.h:17:32: note: in expansion of macro '__compiler_offsetof'
 #define offsetof(TYPE, MEMBER) __compiler_offsetof(TYPE, MEMBER)
                                ^~~~~~~~~~~~~~~~~~~
./include/linux/kernel.h:1015:21: note: in expansion of macro 'offsetof'
  ((type *)(__mptr - offsetof(type, member))); })
                     ^~~~~~~~
/home/phil/rpmbuild/BUILD/iwlegacy-0.0/3945-mac.c:2503:6: note: in expansion of macro 'container_of'
      container_of(data, struct il_priv, _3945.rfkill_poll.work);
      ^~~~~~~~~~~~
/home/phil/rpmbuild/BUILD/iwlegacy-0.0/debug.c: In function 'il_dbgfs_sram_read':
/home/phil/rpmbuild/BUILD/iwlegacy-0.0/debug.c:346:9: error: 'struct il_priv' has no member named 'dbgfs_sram_offset'
  if (!il->dbgfs_sram_offset && !il->dbgfs_sram_len) {
         ^~
/home/phil/rpmbuild/BUILD/iwlegacy-0.0/debug.c:346:35: error: 'struct il_priv' has no member named 'dbgfs_sram_len'
  if (!il->dbgfs_sram_offset && !il->dbgfs_sram_len) {
                                   ^~
/home/phil/rpmbuild/BUILD/iwlegacy-0.0/3945-mac.c:2522:39: error: 'struct il_priv' has no member named '_3945'
  queue_delayed_work(il->workqueue, &il->_3945.rfkill_poll,
                                       ^~
/home/phil/rpmbuild/BUILD/iwlegacy-0.0/debug.c:347:5: error: 'struct il_priv' has no member named 'dbgfs_sram_offset'
   il->dbgfs_sram_offset = 0x800000;
     ^~
/home/phil/rpmbuild/BUILD/iwlegacy-0.0/debug.c:349:6: error: 'struct il_priv' has no member named 'dbgfs_sram_len'
    il->dbgfs_sram_len = il->ucode_init_data.len;
      ^~
/home/phil/rpmbuild/BUILD/iwlegacy-0.0/debug.c:351:6: error: 'struct il_priv' has no member named 'dbgfs_sram_len'
    il->dbgfs_sram_len = il->ucode_data.len;
      ^~
/home/phil/rpmbuild/BUILD/iwlegacy-0.0/debug.c:353:17: error: 'struct il_priv' has no member named 'dbgfs_sram_len'
  bufsz = 30 + il->dbgfs_sram_len * sizeof(char) * 10;
                 ^~
/home/phil/rpmbuild/BUILD/iwlegacy-0.0/debug.c:359:11: error: 'struct il_priv' has no member named 'dbgfs_sram_len'
         il->dbgfs_sram_len);
           ^~
/home/phil/rpmbuild/BUILD/iwlegacy-0.0/debug.c:362:11: error: 'struct il_priv' has no member named 'dbgfs_sram_offset'
         il->dbgfs_sram_offset);
           ^~
/home/phil/rpmbuild/BUILD/iwlegacy-0.0/debug.c:363:13: error: 'struct il_priv' has no member named 'dbgfs_sram_len'
  for (i = il->dbgfs_sram_len; i > 0; i -= 4) {
             ^~
/home/phil/rpmbuild/BUILD/iwlegacy-0.0/debug.c:366:12: error: 'struct il_priv' has no member named 'dbgfs_sram_offset'
          il->dbgfs_sram_offset +
            ^~
/home/phil/rpmbuild/BUILD/iwlegacy-0.0/debug.c:367:12: error: 'struct il_priv' has no member named 'dbgfs_sram_len'
          il->dbgfs_sram_len - i);
            ^~
/home/phil/rpmbuild/BUILD/iwlegacy-0.0/debug.c: In function 'il_dbgfs_sram_write':
/home/phil/rpmbuild/BUILD/iwlegacy-0.0/debug.c:407:5: error: 'struct il_priv' has no member named 'dbgfs_sram_offset'
   il->dbgfs_sram_offset = offset;
     ^~
/home/phil/rpmbuild/BUILD/iwlegacy-0.0/debug.c:408:5: error: 'struct il_priv' has no member named 'dbgfs_sram_len'
   il->dbgfs_sram_len = len;
     ^~
/home/phil/rpmbuild/BUILD/iwlegacy-0.0/debug.c:410:5: error: 'struct il_priv' has no member named 'dbgfs_sram_offset'
   il->dbgfs_sram_offset = 0;
     ^~
/home/phil/rpmbuild/BUILD/iwlegacy-0.0/debug.c:411:5: error: 'struct il_priv' has no member named 'dbgfs_sram_len'
   il->dbgfs_sram_len = 0;
     ^~
/home/phil/rpmbuild/BUILD/iwlegacy-0.0/4965-mac.c: In function 'il4965_static_wepkey_cmd':
/home/phil/rpmbuild/BUILD/iwlegacy-0.0/4965-mac.c:3162:19: error: 'struct il_priv' has no member named '_4965'
   u8 key_size = il->_4965.wep_keys[i].key_size;
                   ^~
/home/phil/rpmbuild/BUILD/iwlegacy-0.0/3945-mac.c: In function 'il3945_mac_start':
/home/phil/rpmbuild/BUILD/iwlegacy-0.0/3945-mac.c:2840:25: error: 'struct il_priv' has no member named '_3945'
  cancel_delayed_work(&il->_3945.rfkill_poll);
                         ^~
/home/phil/rpmbuild/BUILD/iwlegacy-0.0/3945-mac.c: In function 'il3945_mac_stop':
/home/phil/rpmbuild/BUILD/iwlegacy-0.0/4965-mac.c:3172:37: error: 'struct il_priv' has no member named '_4965'
   memcpy(&wep_cmd->key[i].key[3], il->_4965.wep_keys[i].key, key_size);
                                     ^~
/home/phil/rpmbuild/BUILD/iwlegacy-0.0/3945-mac.c:2871:39: error: 'struct il_priv' has no member named '_3945'
  queue_delayed_work(il->workqueue, &il->_3945.rfkill_poll,
                                       ^~
/home/phil/rpmbuild/BUILD/iwlegacy-0.0/4965-mac.c: In function 'il4965_remove_default_wep_key':
/home/phil/rpmbuild/BUILD/iwlegacy-0.0/4965-mac.c:3206:12: error: 'struct il_priv' has no member named '_4965'
  memset(&il->_4965.wep_keys[idx], 0, sizeof(struct il_wep_key));
            ^~
/home/phil/rpmbuild/BUILD/iwlegacy-0.0/4965-mac.c: In function 'il4965_set_default_wep_key':
/home/phil/rpmbuild/BUILD/iwlegacy-0.0/4965-mac.c:3237:4: error: 'struct il_priv' has no member named '_4965'
  il->_4965.wep_keys[idx].key_size = len;
    ^~
/home/phil/rpmbuild/BUILD/iwlegacy-0.0/4965-mac.c:3238:12: error: 'struct il_priv' has no member named '_4965'
  memcpy(&il->_4965.wep_keys[idx].key, &keyconf->key, len);
            ^~
make[1]: *** [scripts/Makefile.build:315: /home/phil/rpmbuild/BUILD/iwlegacy-0.0/4965-debug.o] Error 1
make[1]: *** Waiting for unfinished jobs....
/home/phil/rpmbuild/BUILD/iwlegacy-0.0/4965-mac.c: In function 'il4965_remove_dynamic_key':
/home/phil/rpmbuild/BUILD/iwlegacy-0.0/4965-mac.c:3438:4: error: 'struct il_priv' has no member named '_4965'
  il->_4965.key_mapping_keys--;
    ^~
In file included from ./include/linux/byteorder/little_endian.h:5,
                 from ./arch/x86/include/uapi/asm/byteorder.h:5,
                 from ./include/asm-generic/bitops/le.h:6,
                 from ./arch/x86/include/asm/bitops.h:521,
                 from ./include/linux/bitops.h:38,
                 from ./include/linux/kernel.h:11,
                 from /home/phil/rpmbuild/BUILD/iwlegacy-0.0/3945-mac.c:32:
/home/phil/rpmbuild/BUILD/iwlegacy-0.0/3945-mac.c: In function 'il3945_store_measurement':
/home/phil/rpmbuild/BUILD/iwlegacy-0.0/4965-mac.c: In function 'il4965_set_dynamic_key':
/home/phil/rpmbuild/BUILD/iwlegacy-0.0/4965-mac.c:3496:4: error: 'struct il_priv' has no member named '_4965'
  il->_4965.key_mapping_keys++;
    ^~
/home/phil/rpmbuild/BUILD/iwlegacy-0.0/3945-mac.c:3279:31: error: 'struct il_priv' has no member named '_3945'
   .start_time = cpu_to_le64(il->_3945.last_tsf),
                               ^~
./include/uapi/linux/byteorder/little_endian.h:31:51: note: in definition of macro '__cpu_to_le64'
 #define __cpu_to_le64(x) ((__force __le64)(__u64)(x))
                                                   ^
/home/phil/rpmbuild/BUILD/iwlegacy-0.0/3945-mac.c:3279:17: note: in expansion of macro 'cpu_to_le64'
   .start_time = cpu_to_le64(il->_3945.last_tsf),
                 ^~~~~~~~~~~
/home/phil/rpmbuild/BUILD/iwlegacy-0.0/debug.c: In function 'il_dbgfs_disable_ht40_write':
/home/phil/rpmbuild/BUILD/iwlegacy-0.0/debug.c:806:7: error: 'struct il_priv' has no member named 'disable_ht40'; did you mean 'disable_sens_cal'?
   il->disable_ht40 = ht40 ? true : false;
       ^~~~~~~~~~~~
       disable_sens_cal
/home/phil/rpmbuild/BUILD/iwlegacy-0.0/debug.c: In function 'il_dbgfs_disable_ht40_read':
/home/phil/rpmbuild/BUILD/iwlegacy-0.0/debug.c:827:13: error: 'struct il_priv' has no member named 'disable_ht40'; did you mean 'disable_sens_cal'?
         il->disable_ht40 ? "Disabled" : "Enabled");
             ^~~~~~~~~~~~
             disable_sens_cal
/home/phil/rpmbuild/BUILD/iwlegacy-0.0/debug.c: In function 'il_dbgfs_ucode_rx_stats_read':
/home/phil/rpmbuild/BUILD/iwlegacy-0.0/debug.c:922:11: error: 'struct il_priv' has no member named 'debugfs_ops'
  return il->debugfs_ops->rx_stats_read(file, user_buf, count, ppos);
           ^~
/home/phil/rpmbuild/BUILD/iwlegacy-0.0/debug.c: In function 'il_dbgfs_ucode_tx_stats_read':
/home/phil/rpmbuild/BUILD/iwlegacy-0.0/debug.c:931:11: error: 'struct il_priv' has no member named 'debugfs_ops'
  return il->debugfs_ops->tx_stats_read(file, user_buf, count, ppos);
           ^~
/home/phil/rpmbuild/BUILD/iwlegacy-0.0/debug.c: In function 'il_dbgfs_ucode_general_stats_read':
/home/phil/rpmbuild/BUILD/iwlegacy-0.0/debug.c:940:11: error: 'struct il_priv' has no member named 'debugfs_ops'
  return il->debugfs_ops->general_stats_read(file, user_buf, count, ppos);
           ^~
In file included from ./include/linux/srcu.h:34,
                 from ./include/linux/notifier.h:16,
                 from ./include/linux/memory_hotplug.h:7,
                 from ./include/linux/mmzone.h:785,
                 from ./include/linux/gfp.h:6,
                 from ./include/linux/umh.h:4,
                 from ./include/linux/kmod.h:22,
                 from ./include/linux/module.h:13,
                 from /home/phil/rpmbuild/BUILD/iwlegacy-0.0/3945-mac.c:33:
/home/phil/rpmbuild/BUILD/iwlegacy-0.0/3945-mac.c: In function 'il3945_setup_deferred_work':
/home/phil/rpmbuild/BUILD/iwlegacy-0.0/3945-mac.c:3423:23: error: 'struct il_priv' has no member named '_3945'
  INIT_DELAYED_WORK(&il->_3945.rfkill_poll, il3945_rfkill_poll);
                       ^~
./include/linux/workqueue.h:251:16: note: in definition of macro '__INIT_WORK'
   __init_work((_work), _onstack); \
                ^~~~~
./include/linux/workqueue.h:266:3: note: in expansion of macro 'INIT_WORK'
   INIT_WORK(&(_work)->work, (_func)); \
   ^~~~~~~~~
./include/linux/workqueue.h:281:2: note: in expansion of macro '__INIT_DELAYED_WORK'
  __INIT_DELAYED_WORK(_work, _func, 0)
  ^~~~~~~~~~~~~~~~~~~
/home/phil/rpmbuild/BUILD/iwlegacy-0.0/3945-mac.c:3423:2: note: in expansion of macro 'INIT_DELAYED_WORK'
  INIT_DELAYED_WORK(&il->_3945.rfkill_poll, il3945_rfkill_poll);
  ^~~~~~~~~~~~~~~~~
/home/phil/rpmbuild/BUILD/iwlegacy-0.0/3945-mac.c:3423:23: error: 'struct il_priv' has no member named '_3945'
  INIT_DELAYED_WORK(&il->_3945.rfkill_poll, il3945_rfkill_poll);
                       ^~
./include/linux/workqueue.h:252:4: note: in definition of macro '__INIT_WORK'
   (_work)->data = (atomic_long_t) WORK_DATA_INIT(); \
    ^~~~~
./include/linux/workqueue.h:266:3: note: in expansion of macro 'INIT_WORK'
   INIT_WORK(&(_work)->work, (_func)); \
   ^~~~~~~~~
./include/linux/workqueue.h:281:2: note: in expansion of macro '__INIT_DELAYED_WORK'
  __INIT_DELAYED_WORK(_work, _func, 0)
  ^~~~~~~~~~~~~~~~~~~
/home/phil/rpmbuild/BUILD/iwlegacy-0.0/3945-mac.c:3423:2: note: in expansion of macro 'INIT_DELAYED_WORK'
  INIT_DELAYED_WORK(&il->_3945.rfkill_poll, il3945_rfkill_poll);
  ^~~~~~~~~~~~~~~~~
/home/phil/rpmbuild/BUILD/iwlegacy-0.0/3945-mac.c:3423:23: error: 'struct il_priv' has no member named '_3945'
  INIT_DELAYED_WORK(&il->_3945.rfkill_poll, il3945_rfkill_poll);
                       ^~
./include/linux/workqueue.h:253:20: note: in definition of macro '__INIT_WORK'
   INIT_LIST_HEAD(&(_work)->entry); \
                    ^~~~~
./include/linux/workqueue.h:266:3: note: in expansion of macro 'INIT_WORK'
   INIT_WORK(&(_work)->work, (_func)); \
   ^~~~~~~~~
./include/linux/workqueue.h:281:2: note: in expansion of macro '__INIT_DELAYED_WORK'
  __INIT_DELAYED_WORK(_work, _func, 0)
  ^~~~~~~~~~~~~~~~~~~
/home/phil/rpmbuild/BUILD/iwlegacy-0.0/3945-mac.c:3423:2: note: in expansion of macro 'INIT_DELAYED_WORK'
  INIT_DELAYED_WORK(&il->_3945.rfkill_poll, il3945_rfkill_poll);
  ^~~~~~~~~~~~~~~~~
/home/phil/rpmbuild/BUILD/iwlegacy-0.0/3945-mac.c:3423:23: error: 'struct il_priv' has no member named '_3945'
  INIT_DELAYED_WORK(&il->_3945.rfkill_poll, il3945_rfkill_poll);
                       ^~
./include/linux/workqueue.h:254:4: note: in definition of macro '__INIT_WORK'
   (_work)->func = (_func); \
    ^~~~~
./include/linux/workqueue.h:266:3: note: in expansion of macro 'INIT_WORK'
   INIT_WORK(&(_work)->work, (_func)); \
   ^~~~~~~~~
./include/linux/workqueue.h:281:2: note: in expansion of macro '__INIT_DELAYED_WORK'
  __INIT_DELAYED_WORK(_work, _func, 0)
  ^~~~~~~~~~~~~~~~~~~
/home/phil/rpmbuild/BUILD/iwlegacy-0.0/3945-mac.c:3423:2: note: in expansion of macro 'INIT_DELAYED_WORK'
  INIT_DELAYED_WORK(&il->_3945.rfkill_poll, il3945_rfkill_poll);
  ^~~~~~~~~~~~~~~~~
In file included from ./include/linux/workqueue.h:9,
                 from ./include/linux/srcu.h:34,
                 from ./include/linux/notifier.h:16,
                 from ./include/linux/memory_hotplug.h:7,
                 from ./include/linux/mmzone.h:785,
                 from ./include/linux/gfp.h:6,
                 from ./include/linux/umh.h:4,
                 from ./include/linux/kmod.h:22,
                 from ./include/linux/module.h:13,
                 from /home/phil/rpmbuild/BUILD/iwlegacy-0.0/3945-mac.c:33:
/home/phil/rpmbuild/BUILD/iwlegacy-0.0/3945-mac.c:3423:23: error: 'struct il_priv' has no member named '_3945'
  INIT_DELAYED_WORK(&il->_3945.rfkill_poll, il3945_rfkill_poll);
                       ^~
./include/linux/timer.h:119:18: note: in definition of macro '__init_timer'
  init_timer_key((_timer), (_fn), (_flags), NULL, NULL)
                  ^~~~~~
./include/linux/workqueue.h:281:2: note: in expansion of macro '__INIT_DELAYED_WORK'
  __INIT_DELAYED_WORK(_work, _func, 0)
  ^~~~~~~~~~~~~~~~~~~
/home/phil/rpmbuild/BUILD/iwlegacy-0.0/3945-mac.c:3423:2: note: in expansion of macro 'INIT_DELAYED_WORK'
  INIT_DELAYED_WORK(&il->_3945.rfkill_poll, il3945_rfkill_poll);
  ^~~~~~~~~~~~~~~~~
/home/phil/rpmbuild/BUILD/iwlegacy-0.0/debug.c: At top level:
/home/phil/rpmbuild/BUILD/iwlegacy-0.0/debug.c:1345:1: error: redefinition of 'il_dbgfs_register'
 il_dbgfs_register(struct il_priv *il, const char *name)
 ^~~~~~~~~~~~~~~~~
In file included from /home/phil/rpmbuild/BUILD/iwlegacy-0.0/debug.c:32:
/home/phil/rpmbuild/BUILD/iwlegacy-0.0/common.h:2981:1: note: previous definition of 'il_dbgfs_register' was here
 il_dbgfs_register(struct il_priv *il, const char *name)
 ^~~~~~~~~~~~~~~~~
/home/phil/rpmbuild/BUILD/iwlegacy-0.0/debug.c: In function 'il_dbgfs_register':
/home/phil/rpmbuild/BUILD/iwlegacy-0.0/debug.c:1354:4: error: 'struct il_priv' has no member named 'debugfs_dir'
  il->debugfs_dir = dir_drv;
    ^~
/home/phil/rpmbuild/BUILD/iwlegacy-0.0/debug.c: At top level:
/home/phil/rpmbuild/BUILD/iwlegacy-0.0/debug.c:1416:1: error: redefinition of 'il_dbgfs_unregister'
 il_dbgfs_unregister(struct il_priv *il)
 ^~~~~~~~~~~~~~~~~~~
In file included from /home/phil/rpmbuild/BUILD/iwlegacy-0.0/debug.c:32:
/home/phil/rpmbuild/BUILD/iwlegacy-0.0/common.h:2987:1: note: previous definition of 'il_dbgfs_unregister' was here
 il_dbgfs_unregister(struct il_priv *il)
 ^~~~~~~~~~~~~~~~~~~
/home/phil/rpmbuild/BUILD/iwlegacy-0.0/debug.c: In function 'il_dbgfs_unregister':
/home/phil/rpmbuild/BUILD/iwlegacy-0.0/debug.c:1418:9: error: 'struct il_priv' has no member named 'debugfs_dir'
  if (!il->debugfs_dir)
         ^~
/home/phil/rpmbuild/BUILD/iwlegacy-0.0/debug.c:1421:29: error: 'struct il_priv' has no member named 'debugfs_dir'
  debugfs_remove_recursive(il->debugfs_dir);
                             ^~
/home/phil/rpmbuild/BUILD/iwlegacy-0.0/debug.c:1422:4: error: 'struct il_priv' has no member named 'debugfs_dir'
  il->debugfs_dir = NULL;
    ^~
/home/phil/rpmbuild/BUILD/iwlegacy-0.0/3945-mac.c: In function 'il3945_pci_probe':
/home/phil/rpmbuild/BUILD/iwlegacy-0.0/3945-mac.c:3775:39: error: 'struct il_priv' has no member named '_3945'
  queue_delayed_work(il->workqueue, &il->_3945.rfkill_poll, 2 * HZ);
                                       ^~
/home/phil/rpmbuild/BUILD/iwlegacy-0.0/3945-mac.c: In function 'il3945_pci_remove':
/home/phil/rpmbuild/BUILD/iwlegacy-0.0/3945-mac.c:3849:30: error: 'struct il_priv' has no member named '_3945'
  cancel_delayed_work_sync(&il->_3945.rfkill_poll);
                              ^~
/home/phil/rpmbuild/BUILD/iwlegacy-0.0/4965-mac.c: In function 'il4965_ucode_callback':
make[1]: *** [scripts/Makefile.build:315: /home/phil/rpmbuild/BUILD/iwlegacy-0.0/4965.o] Error 1
/home/phil/rpmbuild/BUILD/iwlegacy-0.0/4965-mac.c:4983:4: error: 'struct il_priv' has no member named '_4965'
  il->_4965.phy_calib_chain_noise_reset_cmd =
    ^~
/home/phil/rpmbuild/BUILD/iwlegacy-0.0/4965-mac.c:4985:4: error: 'struct il_priv' has no member named '_4965'
  il->_4965.phy_calib_chain_noise_gain_cmd =
    ^~
/home/phil/rpmbuild/BUILD/iwlegacy-0.0/4965-mac.c:5010:14: error: 'struct il_priv' has no member named '_4965'
  complete(&il->_4965.firmware_loading_complete);
              ^~
/home/phil/rpmbuild/BUILD/iwlegacy-0.0/4965-mac.c:5024:14: error: 'struct il_priv' has no member named '_4965'
  complete(&il->_4965.firmware_loading_complete);
              ^~
/home/phil/rpmbuild/BUILD/iwlegacy-0.0/4965-mac.c: In function '__il4965_down':
/home/phil/rpmbuild/BUILD/iwlegacy-0.0/4965-mac.c:5402:11: error: 'struct il_priv' has no member named '_4965'
  memset(il->_4965.wep_keys, 0, sizeof(il->_4965.wep_keys));
           ^~
/home/phil/rpmbuild/BUILD/iwlegacy-0.0/4965-mac.c:5402:41: error: 'struct il_priv' has no member named '_4965'
  memset(il->_4965.wep_keys, 0, sizeof(il->_4965.wep_keys));
                                         ^~
/home/phil/rpmbuild/BUILD/iwlegacy-0.0/4965-mac.c:5403:4: error: 'struct il_priv' has no member named '_4965'
  il->_4965.key_mapping_keys = 0;
    ^~
/home/phil/rpmbuild/BUILD/iwlegacy-0.0/debug.c: In function 'il_dbgfs_ucode_general_stats_read':
/home/phil/rpmbuild/BUILD/iwlegacy-0.0/debug.c:941:1: warning: control reaches end of non-void function [-Wreturn-type]
 }
 ^
/home/phil/rpmbuild/BUILD/iwlegacy-0.0/debug.c: In function 'il_dbgfs_ucode_tx_stats_read':
/home/phil/rpmbuild/BUILD/iwlegacy-0.0/debug.c:932:1: warning: control reaches end of non-void function [-Wreturn-type]
 }
 ^
/home/phil/rpmbuild/BUILD/iwlegacy-0.0/debug.c: In function 'il_dbgfs_ucode_rx_stats_read':
/home/phil/rpmbuild/BUILD/iwlegacy-0.0/debug.c:923:1: warning: control reaches end of non-void function [-Wreturn-type]
 }
 ^
/home/phil/rpmbuild/BUILD/iwlegacy-0.0/4965-mac.c: In function 'il4965_bg_run_time_calib_work':
/home/phil/rpmbuild/BUILD/iwlegacy-0.0/4965-mac.c:5687:49: error: 'struct il_priv' has no member named '_4965'
   il4965_chain_noise_calibration(il, (void *)&il->_4965.stats);
                                                 ^~
/home/phil/rpmbuild/BUILD/iwlegacy-0.0/4965-mac.c:5688:49: error: 'struct il_priv' has no member named '_4965'
   il4965_sensitivity_calibration(il, (void *)&il->_4965.stats);
                                                 ^~
/home/phil/rpmbuild/BUILD/iwlegacy-0.0/4965-mac.c: In function 'il4965_mac_set_key':
/home/phil/rpmbuild/BUILD/iwlegacy-0.0/4965-mac.c:5957:28: error: 'struct il_priv' has no member named '_4965'
    is_default_wep_key = !il->_4965.key_mapping_keys;
                            ^~
In file included from ./include/linux/srcutree.h:28,
                 from ./include/linux/srcu.h:62,
                 from ./include/linux/notifier.h:16,
                 from ./include/linux/memory_hotplug.h:7,
                 from ./include/linux/mmzone.h:785,
                 from ./include/linux/gfp.h:6,
                 from ./include/linux/umh.h:4,
                 from ./include/linux/kmod.h:22,
                 from ./include/linux/module.h:13,
                 from /home/phil/rpmbuild/BUILD/iwlegacy-0.0/4965-mac.c:33:
/home/phil/rpmbuild/BUILD/iwlegacy-0.0/4965-mac.c: In function 'il4965_pci_probe':
/home/phil/rpmbuild/BUILD/iwlegacy-0.0/4965-mac.c:6684:21: error: 'struct il_priv' has no member named '_4965'
  init_completion(&il->_4965.firmware_loading_complete);
                     ^~
./include/linux/completion.h:32:46: note: in definition of macro 'init_completion'
 #define init_completion(x) __init_completion(x)
                                              ^
make[1]: *** [scripts/Makefile.build:315: /home/phil/rpmbuild/BUILD/iwlegacy-0.0/debug.o] Error 1
/home/phil/rpmbuild/BUILD/iwlegacy-0.0/4965-mac.c: In function 'il4965_pci_remove':
/home/phil/rpmbuild/BUILD/iwlegacy-0.0/4965-mac.c:6722:25: error: 'struct il_priv' has no member named '_4965'
  wait_for_completion(&il->_4965.firmware_loading_complete);
                         ^~
make[1]: *** [scripts/Makefile.build:315: /home/phil/rpmbuild/BUILD/iwlegacy-0.0/3945-mac.o] Error 1
make[1]: *** [scripts/Makefile.build:315: /home/phil/rpmbuild/BUILD/iwlegacy-0.0/4965-mac.o] Error 1
make: *** [Makefile:1528: _module_/home/phil/rpmbuild/BUILD/iwlegacy-0.0] Error 2
make: Leaving directory '/usr/src/kernels/4.18.0-80.el8.x86_64'
error: Bad exit status from /var/tmp/rpm-tmp.MFf6iP (%build)
bug959-errors.txt (40,802 bytes)   
iwlegacy-0.0.tar.gz (305,421 bytes)

Activities

pseud

2019-10-22 11:36

reporter   ~0006618

Please change Severity to feature, thx

toracat

2019-10-22 11:51

administrator   ~0006619

Done.

toracat

2019-10-22 12:18

administrator   ~0006620

Related CentOS bug entry ( https://bugs.centos.org/view.php?id=16635 ).

pperry

2019-10-24 10:39

administrator   ~0006621

Last edited: 2019-11-02 14:13

 Building from kernel-4.18.20, I'm seeing a LOT of errors (below). I'll try building without debug.

+ /usr/bin/make -C /usr/src/kernels/4.18.0-80.el8.x86_64 -j8 modules M=/home/phil/rpmbuild/BUILD/iwlegacy-0.0
make: Entering directory '/usr/src/kernels/4.18.0-80.el8.x86_64'
  CC [M] /home/phil/rpmbuild/BUILD/iwlegacy-0.0/common.o
  CC [M] /home/phil/rpmbuild/BUILD/iwlegacy-0.0/debug.o
  CC [M] /home/phil/rpmbuild/BUILD/iwlegacy-0.0/4965.o
  CC [M] /home/phil/rpmbuild/BUILD/iwlegacy-0.0/4965-mac.o
  CC [M] /home/phil/rpmbuild/BUILD/iwlegacy-0.0/4965-rs.o
  CC [M] /home/phil/rpmbuild/BUILD/iwlegacy-0.0/4965-calib.o
  CC [M] /home/phil/rpmbuild/BUILD/iwlegacy-0.0/4965-debug.o
  CC [M] /home/phil/rpmbuild/BUILD/iwlegacy-0.0/3945-mac.o
In file included from ./include/linux/byteorder/little_endian.h:5,
                 from ./arch/x86/include/uapi/asm/byteorder.h:5,
                 from ./include/asm-generic/bitops/le.h:6,
                 from ./arch/x86/include/asm/bitops.h:521,
                 from ./include/linux/bitops.h:38,
                 from ./include/linux/kernel.h:11,
                 from ./include/linux/interrupt.h:6,
                 from /home/phil/rpmbuild/BUILD/iwlegacy-0.0/common.h:29,
                 from /home/phil/rpmbuild/BUILD/iwlegacy-0.0/4965-debug.c:28:
/home/phil/rpmbuild/BUILD/iwlegacy-0.0/4965-debug.c: In function 'il4965_stats_flag':
/home/phil/rpmbuild/BUILD/iwlegacy-0.0/4965-debug.c:42:23: error: 'struct il_priv' has no member named '_4965'
  flag = le32_to_cpu(il->_4965.stats.flag);
                       ^~
./include/uapi/linux/byteorder/little_endian.h:34:51: note: in definition of macro '__le32_to_cpu'
 #define __le32_to_cpu(x) ((__force __u32)(__le32)(x))
                                                   ^
/home/phil/rpmbuild/BUILD/iwlegacy-0.0/4965-debug.c:42:9: note: in expansion of macro 'le32_to_cpu'
  flag = le32_to_cpu(il->_4965.stats.flag);
         ^~~~~~~~~~~

The rest of the error output has been uploaded:

https://elrepo.org/bugs/file_download.php?file_id=360&type=bug

pperry

2019-10-24 11:08

administrator   ~0006622

Didn't help building without debug. I'm at a loss as to where these build errors have come from.

As it stands, I'm not able to build the iwlegacy modules.

Akemi - do these build when enabled in the CentOS-Plus kernel?

toracat

2019-10-24 11:15

administrator   ~0006623

Yes, as noted in the corresponding CentOS bug entry, the plus kernel with those modules enabled has been released for testing.

toracat

2019-10-24 11:18

administrator   ~0006624

The plus kernel config diff is:

2740,2741c2740,2748
< # CONFIG_IWL4965 is not set
< # CONFIG_IWL3945 is not set
---
> CONFIG_IWLEGACY=m
> CONFIG_IWL4965=m
> CONFIG_IWL3945=m
>
> #
> # iwl3945 / iwl4965 Debugging Options
> #
> # CONFIG_IWLEGACY_DEBUG is not set
> # CONFIG_IWLEGACY_DEBUGFS is not set

toracat

2019-10-31 11:11

administrator   ~0006636

Last edited: 2019-11-02 14:07

 The same code builds fine with the centosplus kernel in which those modules are enabled.

$ make -C /usr/src/kernels/4.18.0-80.11.2.el8_0.centos.plus.bug16635.x86_64 modules M=`pwd`

iwl3945.ko
iwl4965.ko
iwlegacy.ko

If the distro kernel or the plus kernel without the above modules enabled is used:

$ make -C /usr/src/kernels/4.18.0-80.el8.x86_64 modules M=`pwd` CONFIG_IWLEGACY=m CONFIG_IWL4965=m CONFIG_IWL3945=m
make: Entering directory '/usr/src/kernels/4.18.0-80.el8.x86_64'
  CC [M] /tmp/20/common.o
  LD [M] /tmp/20/iwlegacy.o
  CC [M] /tmp/20/4965.o
/tmp/20/4965.c: In function ‘il4965_hw_get_temperature’:
/tmp/20/4965.c:1585:9: error: ‘struct il_priv’ has no member named ‘_4965’
      (il->_4965.stats.flag & STATS_REPLY_FLG_HT40_MODE_MSK)) {
         ^~
In file included from ./include/linux/byteorder/little_endian.h:5,
                 from ./arch/x86/include/uapi/asm/byteorder.h:5,
                 from ./include/asm-generic/bitops/le.h:6,
                 from ./arch/x86/include/asm/bitops.h:521,
                 from ./include/linux/bitops.h:38,
                 from ./include/linux/kernel.h:11,
                 from /tmp/20/4965.c:27:
/tmp/20/4965.c:1610:11: error: ‘struct il_priv’ has no member named ‘_4965’
        (il->_4965.stats.general.common.temperature),
           ^~
./include/uapi/linux/byteorder/little_endian.h:34:51: note: in definition of macro ‘__le32_to_cpu’
 #define __le32_to_cpu(x) ((__force __u32)(__le32)(x))
                                                   ^
/tmp/20/4965.c:1609:22: note: in expansion of macro ‘le32_to_cpu’
   vt = sign_extend32(le32_to_cpu
                      ^~~~~~~~~~~
make[1]: *** [scripts/Makefile.build:316: /tmp/20/4965.o] Error 1
make: *** [Makefile:1528: _module_/tmp/20] Error 2
make: Leaving directory '/usr/src/kernels/4.18.0-80.el8.x86_64'

pgreco

2019-11-02 16:18

reporter   ~0006646

From what I understand, the problem is that drivers/net/wireless/intel/iwlegacy/common.h is not detecting the CONFIG_4965=m while building iwlegacy itself (missing #define CONFIG_IWL4965_MODULE 1 in autoconf.h).
The easiest way I see is patching something like this
diff --git a/drivers/net/wireless/intel/iwlegacy/common.h b/drivers/net/wireless/intel/iwlegacy/common.h
index dc6a74a..6510c91 100644
--- a/drivers/net/wireless/intel/iwlegacy/common.h
+++ b/drivers/net/wireless/intel/iwlegacy/common.h
@@ -1321,7 +1321,7 @@ struct il_priv {
        u64 timestamp;
 
        union {
-#if IS_ENABLED(CONFIG_IWL3945)
+#if 1
                struct {
                        void *shared_virt;
                        dma_addr_t shared_phys;
@@ -1352,7 +1352,7 @@ struct il_priv {
 
                } _3945;
 #endif
-#if IS_ENABLED(CONFIG_IWL4965)
+#if 1
                struct {
                        struct il_rx_phy_res last_phy_res;
                        bool last_phy_res_valid;


Pablo

toracat

2019-11-02 16:22

administrator   ~0006647

@pgreco

Thank you for your great help. We will give it a try.

pgreco

2019-11-02 16:25

reporter   ~0006648

actually, seems like adding KCFLAGS='-DCONFIG_IWL4965_MODULE -DCONFIG_IWL3945_MODULE' to make has the same effect

toracat

2019-11-02 16:29

administrator   ~0006649

Yes, that seems to be a "better" choice.

By the way the patch did work (of course) !

toracat

2019-11-02 16:33

administrator   ~0006650

@pperry

We can now go ahead and build the kmod. :)

pperry

2019-11-03 07:28

administrator   ~0006651

@pgreco - nice catch :-)

Actually, we need:

KCFLAGS='-DCONFIG_IWLEGACY_DEBUG -DCONFIG_IWLEGACY_DEBUGFS -DCONFIG_IWL4965_MODULE -DCONFIG_IWL3945_MODULE'

so we can enable debug/debugfs too. I enabled it as it's enabled by default on el7.

Package kmod-iwlegacy-0.0-1.el8.elrepo.x86_64.rpm signed and pushed to elrepo repository. If anyone is able to test, that would be great.

dvershinin

2019-12-02 10:27

reporter   ~0006724

kmod-iwlegacy-0.0-1.el8.elrepo.x86_64.rpm works like a breeze.

(Intel 4965AGN Wi-Fi module)

pperry

2019-12-02 12:04

administrator   ~0006725

@dvershinin

Thanks for the feedback - we really appreciate it. There is a new version in the testing repository that has been built for el8.1, which you will need to update to once you've updated to el8.1 (rhel8.1 is out but CentOS has yet to release their el8.1).

pperry

2019-12-08 05:27

administrator   ~0006733

Last edited: 2019-12-08 05:28

 Marking as resolved

Issue History

Date Modified Username Field Change
2019-10-22 11:31 pseud New Issue
2019-10-22 11:31 pseud Status new => assigned
2019-10-22 11:31 pseud Assigned To => toracat
2019-10-22 11:36 pseud Note Added: 0006618
2019-10-22 11:51 toracat Note Added: 0006619
2019-10-22 11:51 toracat Assigned To toracat => pperry
2019-10-22 11:51 toracat Severity major => feature
2019-10-22 12:17 burakkucat Reproducibility always => N/A
2019-10-22 12:18 toracat Note Added: 0006620
2019-10-24 10:39 pperry Note Added: 0006621
2019-10-24 11:08 pperry Note Added: 0006622
2019-10-24 11:15 toracat Note Added: 0006623
2019-10-24 11:18 toracat Note Added: 0006624
2019-10-31 11:11 toracat Note Added: 0006636
2019-11-02 14:07 toracat Note Edited: 0006636
2019-11-02 14:07 toracat Note View State: 6636: public
2019-11-02 14:10 toracat File Added: bug959-errors.txt
2019-11-02 14:13 toracat Note Edited: 0006621
2019-11-02 14:22 toracat File Added: iwlegacy-0.0.tar.gz
2019-11-02 16:18 pgreco Note Added: 0006646
2019-11-02 16:22 toracat Note Added: 0006647
2019-11-02 16:25 pgreco Note Added: 0006648
2019-11-02 16:29 toracat Note Added: 0006649
2019-11-02 16:33 toracat Note Added: 0006650
2019-11-03 07:28 pperry Note Added: 0006651
2019-12-02 10:27 dvershinin Note Added: 0006724
2019-12-02 12:04 pperry Note Added: 0006725
2019-12-08 05:27 pperry Note Added: 0006733
2019-12-08 05:28 pperry Note Edited: 0006733
2019-12-08 05:28 pperry Status assigned => resolved
2019-12-08 05:28 pperry Resolution open => fixed