View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0000833 | channel: kernel/el7 | --kernel--OTHER-- | public | 2018-03-15 14:00 | 2018-06-07 09:46 |
| Reporter | chiluk | Assigned To | burakkucat | ||
| Priority | normal | Severity | minor | Reproducibility | N/A |
| Status | resolved | Resolution | fixed | ||
| Summary | 0000833: AGFL fixup patches are coming | ||||
| Description | AGFL fixup patches are coming. https://patchwork.kernel.org/patch/10285417/ When this patchset reaches mainline and stable we will be able to remove the reversion patch I submitted a few weeks ago via http://elrepo.org/bugs/view.php?id=829 . I will let you know when it lands, but I wanted to give you a heads up. Ideally upstream should have landed both patches simultaneously, and we wouldn't have had to go through this. | ||||
| Tags | No tags attached. | ||||
|
|
Thank you for the advanced notification. You assistance is appreciated. |
|
|
The referenced [1] patch fails to apply to the linux-4.17-rc1 sources. The reason is currently unknown and is under investigation. [1] http://elrepo.org/bugs/view.php?id=829 |
|
|
The patchset can be dropped for 4.17, as the agfl scrub patches have now been integrated with commit a27ba2607e60312554cbcd43fc660b2c7f29dc9c. |
|
|
The above mentioned patch was supposed to have been submitted to the stable trees, but it has not been added there yet. I'll have to check to see what's going on. |
|
|
So we're halfway there. The patchset has been removed from the 4.17-rc1 kernel-ml package sets but will be retained for 4.4.X kernel-lt package sets. |
|
|
Is there any news when those AGFL fixup patches will reach -stable, please? In particular, linux-4.4.X |
|
|
I just checked and upstream sha a27ba2607e603 was not ever applied to 4.4 as I'm sure you've discovered. I just attempted cherry-picking it, and it did not cherry-pick cleanly. I have a feeling that the xfs maintainers may not be pushing this into the stable streams. I will do more research as to why that might be the case, and I'll get back to you. As for now, it appears as if the best course forward is to continue to explictly revert 96f859d52bcb in the 4.4 stream, as that is what Redhat is doing in their Kernels. For 4.17+ removing the reversion will be fine, as it has the fixup patches. Sorry for the slow response, I'm just now getting back from a month of paternity leave. |
|
|
Thank you for the update, it is appreciated. |
|
|
I have backported and submitted the patchset to the stable 4.4 stream, and hope that it will be applied to the other stable streams. Conversation available here. https://www.spinics.net/lists/stable/msg242902.html https://www.spinics.net/lists/stable/msg242903.html Hopefully this is all wrapped up soon-ish. |
|
|
As I see it the patchset needs to find its way to linux-stable, for GKH to then apply. I shall keep watch. Thank you for the links. |
|
|
Greg KH has queued the patches for review by subsystem maintainers. Since this is already in mainline, and was submitted by the maintainers, I have high hopes that it will get a rubber stamp. Assuming all goes according to plan iiuc this should get included with 4.4.136. |
|
|
I can confirm that, earlier today, I saw the patches for the 4.16.14 [1] and 4.14.48 [2] -stable trees. GKH proposes to release both updated source trees this coming Wednesday. The 4.9.106 and 4.4.136 -stable trees, hopefully, will follow. [1] https://lkml.org/lkml/2018/6/4/80 ([PATCH 4.16 12/47] xfs: detect agfl count corruption and reset agfl) [2] https://lkml.org/lkml/2018/6/4/184 ([PATCH 4.14 13/52] xfs: detect agfl count corruption and reset agfl) |
|
|
Updated sources for the linux-4.4.136 -stable tree were released yesterday. With the recent release of the kernel-lt package sets for EL6 [1] and EL7 [2], this fix is now complete for the ELRepo Project's kernel-lt and kernel-ml. Now closing as "resolved/fixed". [1] http://lists.elrepo.org/pipermail/elrepo/2018-June/004296.html [2] http://lists.elrepo.org/pipermail/elrepo/2018-June/004297.html |
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2018-03-15 14:00 | chiluk | New Issue | |
| 2018-03-15 14:00 | chiluk | Status | new => assigned |
| 2018-03-15 14:00 | chiluk | Assigned To | => stindall |
| 2018-03-15 18:13 | burakkucat | Note Added: 0005751 | |
| 2018-03-15 18:13 | burakkucat | Assigned To | stindall => burakkucat |
| 2018-03-15 18:13 | burakkucat | Reproducibility | have not tried => N/A |
| 2018-04-16 10:55 | burakkucat | Note Added: 0005768 | |
| 2018-04-16 12:53 | chiluk | Note Added: 0005769 | |
| 2018-04-16 12:56 | chiluk | Note Added: 0005770 | |
| 2018-04-16 15:36 | burakkucat | Note Added: 0005771 | |
| 2018-05-23 17:18 | burakkucat | Note Added: 0005894 | |
| 2018-05-28 21:34 | chiluk | Note Added: 0005903 | |
| 2018-05-29 07:52 | burakkucat | Note Added: 0005904 | |
| 2018-06-01 10:06 | chiluk | Note Added: 0005918 | |
| 2018-06-01 11:10 | burakkucat | Note Added: 0005919 | |
| 2018-06-03 20:05 | chiluk | Note Added: 0005920 | |
| 2018-06-04 07:03 | burakkucat | Note Added: 0005921 | |
| 2018-06-07 09:46 | burakkucat | Note Added: 0005929 | |
| 2018-06-07 09:46 | burakkucat | Status | assigned => resolved |
| 2018-06-07 09:46 | burakkucat | Resolution | open => fixed |
