View Issue Details

IDProjectCategoryView StatusLast Update
0000721channel: elrepo/el7kmod-nvidia-340xxpublic2017-04-01 07:53
Reporterorion Assigned Topperry  
PrioritynormalSeveritymajorReproducibilityalways
Status closedResolutionwon't fix 
Summary0000721: Do not call weak-modules --remove-modules on upgrade
DescriptionThe %postin script for kmod-nvidia-340xx (and I suspect other kmod packages) have:

if [ -x "/sbin/weak-modules" ]; then
    printf '%s\n' "${modules[@]}" | /sbin/weak-modules --remove-modules
fi

But I don't believe this should be done on upgrade. With the recent ABI break on EL7, updating to the new kmod removed the old kmod from the currently installed older kernels. Perhaps this can't be done and still handle removing the older modules cleanly when needed, but it seems worth looking into.
TagsNo tags attached.
Reported upstream

Activities

pperry

2017-03-06 13:25

administrator   ~0005091

That script is called from within Red Hat's kmodtool. As such, it is not something we want to change as that would alter the expected behaviour of kmod packages on RHEL.

I don't really see what the issue is. You can't install the new kmod package unless you have the corresponding kernel installed that it was built for (due to rpm requires), so you can't accidentally update and break your system. And if you have the new kernel installed, why would you not want the new matching kmod package built for that kernel?

The only potential issue I can see is that backward compatibility is broken, so once you've updated you can no longer boot to older kernels. Unfortunately we can't guarantee backward compatibility with older kernels. If you absolutely need to boot older kernels (with X) then yum downgrade is your friend.

Issue History

Date Modified Username Field Change
2017-03-06 08:56 orion New Issue
2017-03-06 08:56 orion Status new => assigned
2017-03-06 08:56 orion Assigned To => pperry
2017-03-06 13:25 pperry Note Added: 0005091
2017-04-01 07:53 pperry Status assigned => closed
2017-04-01 07:53 pperry Resolution open => won't fix